Fix for IE8 compatibility issue#22
Open
katzmo wants to merge 1 commit intoFormstoneClassic:masterfrom
Open
Conversation
Fixes change event for IE8 so checkboxes are actually clickable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IE8 does not support the standard change event for radios/checkboxes, it uses
propertychangeinstead (see here for more explanations). So when clicking a picker checkbox in IE, nothing happens. This patch fixes the change event for IE8 so checkboxes become clickable.I'm not sure about formstone support for even older IEs? Since there already was a check for IE8 I used that, but older IEs will very likely need this fix, too!