Added hiding fix#80
Open
igoradamenko wants to merge 2 commits intoFormstoneClassic:masterfrom
igoradamenko:master
Open
Added hiding fix#80igoradamenko wants to merge 2 commits intoFormstoneClassic:masterfrom igoradamenko:master
igoradamenko wants to merge 2 commits intoFormstoneClassic:masterfrom
igoradamenko:master
Conversation
.parents starts search from first parent, but we need to start from current element.
.parents starts search from first parent, but we need to start from current element.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you used selecter with scroller and scroll list by mouse (click, hold and drag scroll-bar), after scrolling selecter was hiding if cursor not on scroll-bar. But if change .parents in _onCloseHelper to .closest this bug is fixed.
Now list is not hiding if cursor on list (not only on scroll-bar) after scrolling.
before pull request: https://www.screenr.com/ZykN
after pull request: https://www.screenr.com/kykN