handle commas as decimal separators, formatcheck as amd module#173
handle commas as decimal separators, formatcheck as amd module#173SnakyJake wants to merge 4 commits intoFormulasQuestion:STABLE_5.3from
Conversation
|
As a side note, it is still planned to integrate handling of comma as a decimal separator in future versions (maybe 6.1.x). But unfortunately, it's more complicated than just to replace every occurrence of a comma by a point, as there can be legitimate uses of a comma in the student input. |
|
Ok, nice to know. Than please ignore this pull request. |
|
Good to know that you mainly did it, because you needed it, so I do not make you lose your time. I want to make it very clear that I appreciate your contribution and I hope my answer did not come across hostile. Also, one of the main objectives of my full rewrite was to make it easier for motivated people to contribute, thanks to more modern practices and better documentation in the code. Because when I started maintaining the plugin, I found it very hard to understand all the inner workings of the plugin and thought that it was not particularly "inviting"… |
|
I will now lose this PR, as localised number formatting will be implemented in PR #228 I invite you to have a look over there and submit your feedback or ideas. |
convert formatcheck.js to amd module
handle different decimal separators like commas