Write compatibility layer for unit expressions#181
Open
PhilippImhof wants to merge 8 commits intoFormulasQuestion:mainfrom
Open
Write compatibility layer for unit expressions#181PhilippImhof wants to merge 8 commits intoFormulasQuestion:mainfrom
PhilippImhof wants to merge 8 commits intoFormulasQuestion:mainfrom
Conversation
Pull Request Test Coverage Report for Build 14473980547Details
💛 - Coveralls |
PhilippImhof
force-pushed
the
unit-compat-layer
branch
3 times, most recently
from
e208038 to
845d247
Compare
PhilippImhof
force-pushed
the
unit-compat-layer
branch
from
845d247 to
8f69b81
Compare
PhilippImhof
force-pushed
the
unit-compat-layer
branch
from
8f69b81 to
95093d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing the entire unit conversion code takes time. The aim of this PR is to write a compatibility layer that uses the new parsing system for analysis of unit expressions. We can use this to quickly validate student input (and teacher input in the edit form) and do proper MathJax rendering in quizzes.
The code will convert the input into a string that can be passed to the legacy unit conversion code, allowing to keep the old system in place for a while.