Allow parts to have empty fields#264
Draft
PhilippImhof wants to merge 14 commits intoFormulasQuestion:mainfrom
Draft
Allow parts to have empty fields#264PhilippImhof wants to merge 14 commits intoFormulasQuestion:mainfrom
PhilippImhof wants to merge 14 commits intoFormulasQuestion:mainfrom
Conversation
db98b18 to
220db49
Compare
Collaborator
Author
|
Tests are now passing. This means, the implementation of the new functionality should now no longer break any existing stuff. However, stuff is still not ready yet, because I haven't implemented the tests that actually check whether the new feature really works in various conditions. |
Pull Request Test Coverage Report for Build 17019138792Details
💛 - Coveralls |
0492aae to
b4aac9f
Compare
f09dd62 to
f2b4ec8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will add the following:
$EMPTY. (This concept is borrowed from the excellent STACK plugin, because the people over there are much smarter than I am.)PHP_FLOAT_MAX. The same happens if the student leaves empty a field that is not supposed to be empty. If both the model and the student answer are empty, the difference is 0.is_empty()or something the like, in order for the teacher to be able to check for an empty response.This is currently in a very early stage and should absolutely not be installed on any production server.