feat(test): add test infrastructure and fix test suite (Phase T0) - #13
Merged
Merged
Conversation
- Add secret-scan job (same regex as fortifyroot-sdk-py CI) as a prerequisite for both test jobs - Replace all-tests with non-fr-tests (-- -m "not fr") to avoid overlap with fr-tests job - Fix .env.test.example placeholders to not trigger secret scan - Remove pip cache config (we use uv, not pip)
manas-fortifyroot
force-pushed
the
feat/test-infrastructure-t0a
branch
from
March 28, 2026 06:29
c3e48e7 to
f2797cd
Compare
Remove overly broad KEY=sk- assignment patterns that false-positive on placeholder strings in .env.example and documentation print statements. Exclude *.env.example and *.env.*.example from the scan. The specific provider key patterns (sk-proj-, sk-or-v1-, sk-ant-, gsk_) with minimum length requirements still catch real keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run-tests.shto use per-package isolated venvs (uv sync+uv run pytest) instead of a shared venv, eliminating cross-package dependency conflicts--all,--cassettes,--pythonflags and platform/version-aware skip logicfr-pr.yamlCI: secret scan job + FR tests + non-FR tests across Python 3.10–3.13.env.test.examplefor future test phasesTest results
Test plan
./scripts/run-tests.sh --allpasses on macOS (0 failures)./scripts/run-tests.sh --frpasses on macOS (0 failures)