test: cover custom logging trace correlation - #26
Merged
manas-fortifyroot merged 1 commit intoMay 27, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds focused coverage for FortifyRoot/OpenLLMetry custom stdlib logging correlation behavior.
The original reported empty trace ID behavior is expected when a log is emitted outside any active span. This PR locks the fork-level contract that logs emitted inside an active span carry trace/span correlation, while logs outside active spans remain uncorrelated.
Changes
packages/traceloop-sdk.LogExportResult.SUCCESSwhen available to stay compatible with OTel processor expectations.Validation
uv run pytest tests/test_logging_correlation.py -q./scripts/run-tests.sh --package 'traceloop-sdk'./scripts/run-tests.sh --allcompleted with no failing tests.