Skip to content

Adapt build.cake for teamcity. Make project buildable, add 'Fortis.' … #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AntonSmolkov wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Adapt build.cake for teamcity. Make project buildable, add 'Fortis.' … #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Source/Common.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@
<DebugType>portable</DebugType>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
<AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>
<PackageID>FortisOnline.$(MSBuildProjectName)</PackageID>
Copy link

@MaxShoshin MaxShoshin Jun 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to get prefix somewhere outside?
My idea is push these changes to upstream to allow other contributors to create own teamcity build.

Copy link
Author

@AntonSmolkov AntonSmolkov Jun 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. It's not. Only in csproj files or here

Copy link
Author

@AntonSmolkov AntonSmolkov Jun 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe, replace this property in cake, at build time...

Copy link
Author

@AntonSmolkov AntonSmolkov Jun 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should have discussed your ideas beforehand.
May be it worth creating separate cake file for TeamCity then

</PropertyGroup>
</Project>
1 change: 0 additions & 1 deletion Source/EventFlow.MongoDB/EventFlow.MongoDB.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
<Import Project="../Common.props" />
<PropertyGroup>
<TargetFrameworks>net452;netstandard1.6</TargetFrameworks>
<PackageId>EventFlow.MongoDB</PackageId>
<GenerateAssemblyInfo>True</GenerateAssemblyInfo>
<GeneratePackageOnBuild>False</GeneratePackageOnBuild>
<PackageRequireLicenseAcceptance>True</PackageRequireLicenseAcceptance>
Expand Down
2 changes: 1 addition & 1 deletion Source/EventFlow.SQLite.Tests/EventFlow.SQLite.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
</ItemGroup>
<ItemGroup>
<PackageReference Include="NUnit3TestAdapter" Version="3.13.0" />
<PackageReference Include="System.Data.SQLite" Version="1.0.109.1" />
<PackageReference Include="System.Data.SQLite" Version="1.0.112.2" />
Copy link

@MaxShoshin MaxShoshin Jun 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link

@MaxShoshin MaxShoshin Jun 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that we need to update versions without necessary

Copy link
Author

@AntonSmolkov AntonSmolkov Jun 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not build with this version and also could not find it at nuget.org.
Now it works. Somehow related to our local nuget feed temporarty issues

Copy link

@MaxShoshin MaxShoshin Jun 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is unlisted package, but it exists on nuget.org. Upstream appveyor biuld it (me too). So I disagree with version update.

Copy link
Author

@AntonSmolkov AntonSmolkov Jun 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it now. Ok

</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\EventFlow.SQLite\EventFlow.SQLite.csproj" />
Expand Down
2 changes: 1 addition & 1 deletion Source/EventFlow.SQLite/EventFlow.SQLite.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<ItemGroup>
<PackageReference Include="dbup-sqlserver" Version="4.1.0" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All" />
<PackageReference Include="System.Data.SQLite" Version="1.0.109.1" />
<PackageReference Include="System.Data.SQLite" Version="1.0.112.2" />
</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 2 additions & 0 deletions Source/EventFlow.TestHelpers/EventFlow.TestHelpers.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,15 @@
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All" />
<PackageReference Include="Moq" Version="4.7.99" />
<PackageReference Include="NUnit" Version="3.11.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.8.0" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
<PackageReference Include="System.Data.SqlClient" Version="4.3.0" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'net452'">
<PackageReference Include="TeamCity.VSTest.TestAdapter" Version="1.0.15" />
<Reference Include="System.Management" />
<Reference Include="System.Net.Http" />
</ItemGroup>
Expand Down
Loading