Skip to content

fix: match required check terminal conclusions#21

Merged
mberman84 merged 1 commit into
Forward-Future:mainfrom
coygeek:droid/issue-16-required-check-conclusions
Jun 22, 2026
Merged

fix: match required check terminal conclusions#21
mberman84 merged 1 commit into
Forward-Future:mainfrom
coygeek:droid/issue-16-required-check-conclusions

Conversation

@coygeek

@coygeek coygeek commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Treat SUCCESS, SKIPPED, and NEUTRAL as passing terminal required-check states.
  • Treat STARTUP_FAILURE as a terminal failed required-check state.
  • Add regression coverage for skipped, neutral, and startup failure conclusions.

Validation

  • PYTHONPATH=src python3 -m pytest tests/test_cli.py -q
  • PYTHONPATH=src python3 -m pytest -q
  • PYTHONPATH=src python3 -m ruff check .
  • autoreview --mode local --engine droid: clean, no accepted/actionable findings

Closes #16

@mberman84 mberman84 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The required-check conclusion mapping is sound, but this submitted head is blocked on current main: it conflicts in tests/test_cli.py, and GitHub CI has not run (action_required). Please rebase onto current main, preserve the newer exact-commit/integration coverage, and reconcile this reducer with #22 so PASSED_CHECK_STATES survives the identity aggregation. Re-request review on the updated head.

Comment thread tests/test_cli.py
)

def test_required_checks_do_not_accept_skipped(self) -> None:
def test_required_checks_accept_passing_terminal_conclusions(self) -> None:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This replacement test conflicts with the newer tests on current main. Please rebase and preserve both sets of coverage. While resolving the shared reducer with #22, make sure SKIPPED and NEUTRAL remain passing for every retained check identity.

@coygeek
coygeek force-pushed the droid/issue-16-required-check-conclusions branch from 3cc754f to ad93bb3 Compare June 21, 2026 16:28
@coygeek

coygeek commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

Addressed the review feedback in the updated head. Rebased onto current main, preserved the newer check coverage, and kept the required-check reducer aligned with GitHub semantics for success/skipped/neutral passing states and startup failure as terminal failure.

Verification: PYTHONPATH=src uv run --with pytest --with ruff python -m pytest tests/test_cli.py -q and uv run --with ruff ruff check src tests both pass.

Treat GitHub skipped and neutral required-check conclusions as passing terminal states, and classify startup failures as failed so queue evaluation matches GitHub.

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
@mberman84
mberman84 force-pushed the droid/issue-16-required-check-conclusions branch from ad93bb3 to ba135f1 Compare June 22, 2026 14:19

@mberman84 mberman84 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed on current main after the requested reconciliation. Full suite: 219 passed, 3 skipped, 202 subtests; Ruff and package build pass; structured autoreview reports no actionable findings.

@mberman84
mberman84 merged commit 8858aab into Forward-Future:main Jun 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Match GitHub required-check conclusions for skipped, neutral, and startup failure

2 participants