fix: match required check terminal conclusions#21
Conversation
mberman84
left a comment
There was a problem hiding this comment.
The required-check conclusion mapping is sound, but this submitted head is blocked on current main: it conflicts in tests/test_cli.py, and GitHub CI has not run (action_required). Please rebase onto current main, preserve the newer exact-commit/integration coverage, and reconcile this reducer with #22 so PASSED_CHECK_STATES survives the identity aggregation. Re-request review on the updated head.
| ) | ||
|
|
||
| def test_required_checks_do_not_accept_skipped(self) -> None: | ||
| def test_required_checks_accept_passing_terminal_conclusions(self) -> None: |
There was a problem hiding this comment.
This replacement test conflicts with the newer tests on current main. Please rebase and preserve both sets of coverage. While resolving the shared reducer with #22, make sure SKIPPED and NEUTRAL remain passing for every retained check identity.
3cc754f to
ad93bb3
Compare
|
Addressed the review feedback in the updated head. Rebased onto current main, preserved the newer check coverage, and kept the required-check reducer aligned with GitHub semantics for success/skipped/neutral passing states and startup failure as terminal failure. Verification: |
Treat GitHub skipped and neutral required-check conclusions as passing terminal states, and classify startup failures as failed so queue evaluation matches GitHub. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
ad93bb3 to
ba135f1
Compare
mberman84
left a comment
There was a problem hiding this comment.
Re-reviewed on current main after the requested reconciliation. Full suite: 219 passed, 3 skipped, 202 subtests; Ruff and package build pass; structured autoreview reports no actionable findings.
Summary
Validation
PYTHONPATH=src python3 -m pytest tests/test_cli.py -qPYTHONPATH=src python3 -m pytest -qPYTHONPATH=src python3 -m ruff check .autoreview --mode local --engine droid: clean, no accepted/actionable findingsCloses #16