fix: harden workflow_run coordinator wakes#26
Conversation
mberman84
left a comment
There was a problem hiding this comment.
Requesting one portability fix. The README tells users to install this example on the repository's default branch, but the new static trigger silently disables workflow_run wakeups when that branch is named master, trunk, or anything other than main. Keep the same-repository/non-PR/default-branch job guard, but remove the static filter or substitute the actual branch during installation and document that step. GitHub CI is still action_required; re-request review after updating the head.
| # DeployBot follows. If CI intentionally hands off from a protected release | ||
| # branch, replace both this filter and the workflow_run head_branch guard | ||
| # below with that exact protected branch name or allowlist. | ||
| branches: [main] |
There was a problem hiding this comment.
Hard-coding main makes the reusable example stop receiving workflow_run events for repositories with a differently named default branch, even though the job guard below is correctly dynamic. Remove this static filter and rely on the guard, or make installation substitute the repository's actual default branch and document/test that substitution.
93e6abf to
70f87f2
Compare
|
Addressed the review feedback in the updated head. Removed the hard-coded Verification: |
Restrict privileged workflow_run wakeups to recognized completed conclusions from the same repository and default branch while documenting release-branch adaptation. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
70f87f2 to
625d217
Compare
mberman84
left a comment
There was a problem hiding this comment.
Re-reviewed and repaired on latest main. Moved YAML guidance outside the folded expression, excluded both pull_request and pull_request_target wakeups, and added regression assertions. Full suite: 227 passed, 3 skipped, 202 subtests; Ruff clean; final structured autoreview clean.
Summary
Closes #20
Verification
PATH="$PWD/.venv/bin:$PATH" python3 -m pytest -q./.venv/bin/ruff check src tests./.venv/bin/python -m unittest discover -s tests -v./.venv/bin/python -m buildautoreview --mode local --engine droid: clean; default Codex autoreview hit account usage limit after retries