feat: add support for dual apps with Android profiles#357
feat: add support for dual apps with Android profiles#357svenburkard wants to merge 9 commits intoFossifyOrg:mainfrom
Conversation
|
I'll take a look at it the weekend to make the detekt check happy. |
|
Hi @naveensingh, I've fixed the open detekt violations via 6938e1b, c4de678 and a5c756a. I also rebuilt the APK from last commit (a5c756a) and repeated the tests with Android 16 another time successfully. Regarding commit c4de678: I’m not fully happy with the naming there. I mainly chose this approach to resolve the detekt magic-number violation. If you would have handled that differently or prefer an alternative solution like suppress, please let me know. I’d be happy to get your review when you have time. Thanks a lot, |
|
@svenburkard Are these merge conflicts something you can have a look at? Thanks! |
I can have a look at the weekend, but looks like its only CHANGELOG related conflicts, which will happen by nature if PRs keep open for longer. But to be honest @doodhout, even when fixed I do not have the feeling that we will see a merge anytime soon, as I opened several PRs also with fixes for really annoying bugs which did not get any feedback in the last 2 months (only #363 got merged so far). For that reason I also stopped investing time and am still using the stg branch on my devices for now with all fixes I worked on and also profile-tabs, without opening additional PRs upstream. |
Type of change(s)
What changed and why
Tests performed
Before & after preview
Closes the following issue(s)
Checklist
CHANGELOG.md(if applicable).