Draft
Conversation
ScottDugas
force-pushed
the
copy-update-catalog
branch
from
8bc426e to
8ff7d10
Compare
ScottDugas
commented
Feb 10, 2026
...ational-core/src/main/java/com/apple/foundationdb/relational/recordlayer/query/CopyPlan.java
Show resolved
Hide resolved
This menas that it should work regardless of the path structure, as long as there is a supporting catalog
This required making the database URI more permissive to allow `-`, which should be fine as long as it's quoted, but I suspect more needs to be allowed.
ScottDugas
force-pushed
the
copy-update-catalog
branch
from
8ff7d10 to
050fee3
Compare
This required reworking a bunch of helpers
by making them static, I reduce the chance of a test accidentally using the wrong cluster if it's trying to do multi-cluster
I kind of pushed through to get it working, but I don't know the architecture well enough to say whether other things will break
This feels a bit hacky, but somewhat reasonable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.