Prevent rebuildIndexes from concurrent index state changes#3999
Draft
jjezra wants to merge 3 commits intoFoundationDB:mainfrom
Draft
Prevent rebuildIndexes from concurrent index state changes#3999jjezra wants to merge 3 commits intoFoundationDB:mainfrom
jjezra wants to merge 3 commits intoFoundationDB:mainfrom
Conversation
These index state changes are protected by semaphores, and doing them in multiple threads was oaccasionally causing a failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These index state changes are protected by semaphores, and doing them in multiple threads
was occasionally causing a failure.
This PR should change
rebuildIndexesto first rebuild (i.e. build inline) as a multi-target all the indexes that are targeted to become readable and then:- raise index state write semaphore
- locklessly change the states of all indexes and clear data (if needed). if rebuild had failed (very rare) convert all the desired READABLE to DISABLED.
- release the index state write semaphore
This PR is intended to be followed by another one that simplifies the index rebuild/state-change mechanism and probably move it to an external class.