Preserve unconstrained placeholders in AndPredicate#and()#4090
Merged
normen662 merged 1 commit intoFoundationDB:mainfrom Apr 20, 2026
Merged
Preserve unconstrained placeholders in AndPredicate#and()#4090normen662 merged 1 commit intoFoundationDB:mainfrom
AndPredicate#and()#4090normen662 merged 1 commit intoFoundationDB:mainfrom
Conversation
RobertBrunel
force-pushed
the
and-tautologies
branch
2 times, most recently
from
e343793 to
a2c5f50
Compare
normen662
requested changes
Apr 20, 2026
This change fixes the conjuncts filter in `and()`. Previously, it silently removed unconstrained `Placeholder` instances from the resulting `AndPredicate`. Such placeholders are tautologies but must be kept for the index-matching machinery to work correctly. Removing them can cause incorrect or missed index matches. Testing: * Regression test in `QueryPredicateTest.java`. This fixes FoundationDB#4091.
RobertBrunel
force-pushed
the
and-tautologies
branch
from
0a0c8db to
711ad02
Compare
normen662
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes the conjuncts filter in
and(). Previously, it silently removed unconstrainedPlaceholderinstances from the resultingAndPredicate. Such placeholders are tautologies but must be kept for the index-matching machinery to work correctly. Removing them can cause incorrect or missed index matches.Testing:
QueryPredicateTest.java.This fixes #4091.