Skip to content

uncomment like.yamsql explains#4094

Merged
g31pranjal merged 1 commit intoFoundationDB:mainfrom
g31pranjal:like_yamsql_explains
Apr 17, 2026
Merged

uncomment like.yamsql explains#4094
g31pranjal merged 1 commit intoFoundationDB:mainfrom
g31pranjal:like_yamsql_explains

Conversation

@g31pranjal
Copy link
Copy Markdown
Member

@g31pranjal g31pranjal commented Apr 17, 2026

Explains can now work given # TODO (Investigate Missing binding for __const_CONSTANT error with queries when using plan from cache) is now fixed in #4088

@github-actions
Copy link
Copy Markdown

📊 Metrics Diff Analysis Report

Summary

  • New queries: 9
  • Dropped queries: 9
  • Plan changed + metrics changed: 0
  • Plan unchanged + metrics changed: 0
ℹ️ About this analysis

This automated analysis compares query planner metrics between the base branch and this PR. It categorizes changes into:

  • New queries: Queries added in this PR
  • Dropped queries: Queries removed in this PR. These should be reviewed to ensure we are not losing coverage.
  • Plan changed + metrics changed: The query plan has changed along with planner metrics.
  • Metrics only changed: Same plan but different metrics

The last category in particular may indicate planner regressions that should be investigated.

New Queries

Count of new queries by file:

  • yaml-tests/src/test/resources/like.metrics.yaml: 9

Dropped Queries

The following queries with metrics were removed:

The reviewer should double check that these queries were removed intentionally to avoid a loss of coverage.

@g31pranjal g31pranjal added the cleanup Style/code cleanup with no behavioral change label Apr 17, 2026
@g31pranjal g31pranjal added testing improvement Change that improves our testing and removed cleanup Style/code cleanup with no behavioral change labels Apr 17, 2026
@g31pranjal g31pranjal merged commit 61c7ac7 into FoundationDB:main Apr 17, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing improvement Change that improves our testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants