Join two unjoined futures in FDBRecordStoreRepairHeaderTest#4096
Merged
jjezra merged 1 commit intoFoundationDB:mainfrom Apr 21, 2026
Merged
Join two unjoined futures in FDBRecordStoreRepairHeaderTest#4096jjezra merged 1 commit intoFoundationDB:mainfrom
jjezra merged 1 commit intoFoundationDB:mainfrom
Conversation
I noticed some rare flakiness in repairWithIndexes, and have not been able to reproduce, but noticed these two spots where futures were not joined which could have been the cause.
jjezra
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed some rare flakiness in repairWithIndexes, and have not been able to reproduce, but noticed these two spots where futures were not joined which could have been the cause.