Skip to content

Hotfix/AdvancedOptions#186

Merged
jupster merged 16 commits intoHotfix/net8from
hotfix/logobjectsnotfound
Jul 20, 2025
Merged

Hotfix/AdvancedOptions#186
jupster merged 16 commits intoHotfix/net8from
hotfix/logobjectsnotfound

Conversation

@jupster
Copy link
Collaborator

@jupster jupster commented May 28, 2024

Description

Fixes Advanced Options

Motivation and Context

Closes 184

How Has This Been Tested?

With tears

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

*Still to fix Output to update on click rather then on click of something outside of Advanced Options 🟢

@jupster jupster added bug Something isn't working cleanup change labels May 28, 2024
@jupster jupster added this to the 1.9 milestone May 28, 2024
@jupster jupster self-assigned this May 28, 2024
@jupster jupster linked an issue May 28, 2024 that may be closed by this pull request
@sonarqubecloud
Copy link

@jupster
Copy link
Collaborator Author

jupster commented Oct 11, 2024

Sonar out here emailing me now 😑

@jupster jupster marked this pull request as ready for review October 13, 2024 11:55
Aligned variable declarations for consistency in Arma3Profile and BasicCfg. Removed unused properties and redundant event handling from ServerCfg. Ensured AdvancedOptions and its content are properly initialized in ServerProfile constructors.
@jupster
Copy link
Collaborator Author

jupster commented Jul 5, 2025

it is implemented properly. Output fixed as well. Just need to fix what i broke this push.

jupster added 3 commits July 5, 2025 13:51
Corrected inconsistent indentation for assignment of AdvancedOptionsContent in the ServerProfile class constructor to improve code readability.
Corrected typos in comments and property change notifications.
Corrects the assignment to set AdvancedOptionsContent instead of overwriting ServerCfgContent with advanced options in ServerProfile.cs.
@jupster
Copy link
Collaborator Author

jupster commented Jul 17, 2025

Prepare

class sockets {
    MaxBandwidth = "12Mbps";     // Per-client cap
    initBandwidth = "2Mbps";     // Supports weaker ISPs
};

Prepare

-keysFolder= command line parameter

@jupster jupster changed the base branch from master to feature/Update-1.9 July 20, 2025 10:14
@jupster jupster changed the base branch from feature/Update-1.9 to Hotfix/net8 July 20, 2025 10:17
@jupster jupster merged commit 788a8a7 into Hotfix/net8 Jul 20, 2025
0 of 5 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in FASTER Jul 20, 2025
@jupster jupster deleted the hotfix/logobjectsnotfound branch July 20, 2025 10:18
jupster added a commit that referenced this pull request Jul 25, 2025
jupster added a commit that referenced this pull request Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working change cleanup

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[BUG]LogObjectNotFound not implemented correctly

1 participant