Robust Error handling + security audit#3
Merged
Merged
Conversation
… the fatal error scenario
4nche
reviewed
May 9, 2025
| TokenMigration[] | ||
| > { | ||
| if (!db) { | ||
| throw new Error("Database not initialized"); |
There was a problem hiding this comment.
instead of erroring, maybe try to initialize the database again?
Member
Author
There was a problem hiding this comment.
I looked into it, and it could be done, but I don't think it's worth it. After all the db gets initialized as the 2nd thing in main(). These errors shouldn't happen, I added them more to appease Typescript. The connection to the DB certainly could be dropped, which would give an error, but the db object will never be null after the initialization.
Member
Author
There was a problem hiding this comment.
@4nche if you agree, can you merge this so dylan can deploy it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor some things and also add robust error handling, specially in…the fatal error scenario