Open
Conversation
…han running through the maths fix #471 - and is a slight optimisation
…an works fine as long as the longitude difference is under 180 degrees
… antimeridian. no odd straight line segments leaflet doesn't have particularly great handling for this, but this is a reasonable measure for now
… to be an odd rounding problem not ideal, but better than the current situation
…e - based on simpler lon->lat formula rather than N intermediate points more than good enough for line drawing, and hopefully will avoid odd rounding issues seen on mobile
…l range circles at smaller sizes
…peration for leaflet 0.8
… used by the s2 geometry library this library is used in the ingress backend, so distance calculation, etc are far closer if we use the value from that
This was referenced Feb 18, 2019
Author
|
964e3d4 is problematic: see iitc-project/ingress-intel-total-conversion#1011 |
…/editing process fix IITC-CE/ingress-intel-total-conversion#178 upstream report: Leaflet/Leaflet#6656
_mRadius => _radius
johnd0e
force-pushed
the
master
branch
9 times, most recently
from
76a18f8 to
56b56af
Compare
johnd0e
force-pushed
the
master
branch
3 times, most recently
from
f1464f7 to
54f7666
Compare
added 5 commits
August 9, 2019 18:42
- `points` variable was undeclared - eslint: no-undef, eqeqeq, semi, no-trailing-spaces - fix url, fix mistypes in comments - clean up obsolete MultiPoly* code (that was already commented out) - remove unused `spliceLatLngs` - make L.GeodesicCircle constructor signature compatible to Leaflet 1.x L.Circle - update README.md
get rid of unneeded submodules and dependencies
johnd0e
force-pushed
the
master
branch
2 times, most recently
from
0224c15 to
39c4fba
Compare
added 10 commits
August 23, 2019 14:57
very minor (mostly) space-related changes
use common mixin instead of custom factory function
So it's now possible to override values, e.g.:
```
L.GeodesicCircle.mergeOptions({ // default:
segmentsCoeff: 500, // 1000
segmentsMin: 96 // 48
});
var polyOptions = { segmentsCoeff: 500 }; // 5000
L.GeodesicPolyline.mergeOptions(polyOptions);
L.GeodesicPolygon.mergeOptions(polyOptions);
```
this._geodesicConvertLines expects normalized coords array
reformat "Latitude of point on GC" formula to exactly match ref: http://www.edwilliams.org/avform.htm#Int remove excessive L.LatLng constructor
for the sake of greater consistency start/end points added in processPoly
Refactor for easy options/methods overriding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picked from https://github.com/IITC-CE/ingress-intel-total-conversion/commits/master/external/L.Geodesic.js
This change is