Skip to content

pre-commit alternative to explicit GitHub Actions for formatting#440

Draft
knoepfel wants to merge 3 commits intoFramework-R-D:mainfrom
knoepfel:pre-commit-workflow
Draft

pre-commit alternative to explicit GitHub Actions for formatting#440
knoepfel wants to merge 3 commits intoFramework-R-D:mainfrom
knoepfel:pre-commit-workflow

Conversation

@knoepfel
Copy link
Member

@knoepfel knoepfel commented Mar 20, 2026

This PR pursues an alternative to explicit GitHub actions for checking/applying code-formatting. I am interested in pursuing this option because it:

  1. substantially reduces the code we maintain (leveraging pre-commit's facilities)
  2. retains a common point of maintenance for those who want to apply pre-commit interactively vs. the CI.

@knoepfel knoepfel marked this pull request as draft March 20, 2026 20:10
@greenc-FNAL
Copy link
Contributor

Review the full CodeQL report for details.

@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
+ Coverage   84.94%   85.00%   +0.05%     
==========================================
  Files         127      127              
  Lines        3341     3341              
  Branches      574      574              
==========================================
+ Hits         2838     2840       +2     
  Misses        306      306              
+ Partials      197      195       -2     
Flag Coverage Δ
unittests 85.00% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aff8ec0...b26aae3. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants