chromium_ec: Add host command to read board ID

[JohnAZoidberg]

No description provided.

[JohnAZoidberg]

Need to add a command to read them and a note that it's not supported on all platforms.

[Copilot]

Pull request overview

This PR adds functionality to read and display board IDs for various hardware components via a new host command to the Chromium EC. The implementation introduces a new --boardid command-line flag that queries the EC for board IDs of different components like the mainboard, power button board, touchpad, audio board, and dGPU modules.

Changes:

• Added EC host command (ReadBoardId) to query board IDs from the embedded controller
• Implemented command-line flag --boardid to trigger board ID reading
• Created board ID type enumeration for different hardware components

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
framework_lib/src/chromium_ec/command.rs	Added new EC command enum value for ReadBoardId
framework_lib/src/chromium_ec/commands.rs	Defined BoardIdType enum and request/response structures for board ID reading
framework_lib/src/chromium_ec/mod.rs	Implemented read_board_id_hc method to handle board ID queries
framework_lib/src/commandline/mod.rs	Added boardid CLI field and print_board_ids function to display results
framework_lib/src/commandline/clap_std.rs	Added boardid argument to clap CLI parser
framework_lib/src/commandline/uefi.rs	Added boardid argument to UEFI CLI parser

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The magic numbers -1 and 15 should be defined as named constants to improve code clarity. Consider defining constants like BOARD_ID_INVALID = -1 and BOARD_ID_NOT_PRESENT = 15 near the function or in the BoardIdType enum implementation.

Suggested change

	pub fn read_board_id_hc(&self, board_id_type: BoardIdType) -> EcResult<Option<u8>> {
	let res = EcRequestReadBoardId {
	board_id_type: board_id_type as u8,
	}
	.send_command(self)?;
	match res.board_id {
	-1 => Err(EcError::DeviceError(format!(
	"Failed to read Board ID {:?}",
	board_id_type
	))),
	15 => Ok(None),
	0..=14 => Ok(Some(res.board_id as u8)),
	const BOARD_ID_INVALID: i32 = -1;
	const BOARD_ID_NOT_PRESENT: i32 = 15;
	const BOARD_ID_MAX_VALID: i32 = BOARD_ID_NOT_PRESENT - 1;
	pub fn read_board_id_hc(&self, board_id_type: BoardIdType) -> EcResult<Option<u8>> {
	let res = EcRequestReadBoardId {
	board_id_type: board_id_type as u8,
	}
	.send_command(self)?;
	match res.board_id {
	BOARD_ID_INVALID => Err(EcError::DeviceError(format!(
	"Failed to read Board ID {:?}",
	board_id_type
	))),
	BOARD_ID_NOT_PRESENT => Ok(None),
	0..=BOARD_ID_MAX_VALID => Ok(Some(res.board_id as u8)),

[JohnAZoidberg]

Hm let's not do that for now

[Copilot]

The comment describes the special values but doesn't explain what values 0-14 represent. Add documentation explaining that valid board IDs are in the range 0-14.

Suggested change

	/// Board ID (-1 invalid, 15 not present)
	/// Board ID: 0–14 valid, -1 invalid, 15 not present