Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current verison of ArtiaX / copick, when a user does the following sequence:
The actions work as intended. However, if a user does the following:
The last delete particle, even though only intended for one particle, deletes all the particles.
This is due to a Numpy broadcasting issue somewhere in the code, which might exist in ChimeraX.
What ends up happening is in (see PR, or
src/particle/ParticleList.py):the
np.logical_or()evaluates to all true during the bugged action sequence, becausescm.position_mask()ends up being all true, Tracing through the inherited classes, we end up with the_position_maskcall of the Drawing class in ChimeraX, which seems to possibly be doing some broadcasting errors somewhere in the ChimeraX codebase: https://github.com/RBVI/ChimeraX/blob/56c7172631f802908efe39dda35eb8ec9a6e6baa/src/bundles/graphics/src/drawing.py#L967I can go more down this rabbithole if desired, but the fix I've provided just skips that all entirely and just determines the
selected_particlesin a more intuitive way.