Large crate rework using component hooks and task pools#29
Open
vertesians wants to merge 8 commits intoFraserLee:mainfrom
Open
Large crate rework using component hooks and task pools#29vertesians wants to merge 8 commits intoFraserLee:mainfrom
vertesians wants to merge 8 commits intoFraserLee:mainfrom
Conversation
(squashed commit)
Owner
|
Thanks for the work on this. I'm pretty busy at the moment, but @beaumccartney should be able to take a look at this one. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh, where do I begin...
Assetcalled aBillboard. Billboards are created from aHandle<Imge>(and optionally aHandle<TextureAtlasLayout>) and handle creating the mesh and other tasks needed to prepare a 3D sprite. AHandle<Billboard>is associated with an entity by inserting theSprite3dBillboardcomponent.Sprite3dBuilder,Sprite3dParams, andSprite3dBundlehave been removed.Handle<Billboard>instead.Sprite3dBundlewould include defaults forStandardMaterialthat worked well with 3d sprites. Since the bundle was removed, the utility functionbevy_sprite3d::utils::materialwas added to provide a convenient source for these defaults.Sprite3dBillboardinserts a preconfiguredMeshMaterial3dif not overriden, so you usually don't need to use it.I don't know if this PR will be accepted since it changes so much, but might as well put it out there.