Add limit the number of videos displayed for each channel should be set to a max of 15 when RSS is enabled/forced#9327
Open
ozrendev wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
PR: waiting for review
Contributor
Author
|
I think it should remember the user's last value, while the settings are linked, it still is technically a separate setting. Although maybe if the value is already at the max, it could be safely assumed the user would like it maximized either way? It also makes it clearer the maximum value has changed cap-2026-06-27_16.25.21.mp4 |
Member
|
Behaviour explained and shown in screencap seems fine to me, so lets go with that |
auto-merge was automatically disabled
June 27, 2026 09:44
Head branch was pushed to by a user without write access
Member
|
Oh hmm lets say i deliberately choose to only see 20 (or anything above 15) without rss. Now i enable/disable rss and it will jump to 30. Isnt that undesired? |
Contributor
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
closes #8105
Description
Updates the UI so that when fetching feeds via RSS is enabled, the max video slider value is capped at 15 (technical limitation of RSS feed fetching)
Testing
Go to Settings -> Subscription
Ensure 'Limit the number of videos displayed for each channel' is enabled
Toggle 'Fetch feeds from RSS' and change the value slider
See what the limit is 15 when RSS is enabled and the limit is 30 when RSS is disabled
In all cases, confirm the number of videos displayed on the Subscription page matches the value slider
Additional context
Was unsure if the RSS disabled/enabled values should be set as variables, if anyone has feedback on this?