Fix dev restart not killing old process in macOS#9380
Open
PikachuEXE wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
PR: dependencies
PikachuEXE
changed the title
github-actions
Bot
added
PR: merge conflicts / rebase needed
and removed
PR: waiting for review
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
PikachuEXE
force-pushed
the
dev/fix-dev-restart-macos
branch
from
ecd8ee7 to
87e16bc
Compare
Contributor
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
PikachuEXE
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Jul 6, 2026
Member
Author
|
Last reviewer please let #9378 be merged first (as this includes that |
github-actions
Bot
added
PR: merge conflicts / rebase needed
and removed
PR: waiting for review
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
PikachuEXE
force-pushed
the
dev/fix-dev-restart-macos
branch
from
87e16bc to
4b6d106
Compare
Contributor
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
PikachuEXE
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jul 11, 2026
absidue
approved these changes
Jul 11, 2026
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Based on #9378 (but does not requires it
Description
FT dev restarts on file changes (render/main/preload/botGuardScript) (see
_scripts/dev-runner.jskillElectronis run with pid (if present) and usestree-killwhich does not work properly on macOSIt does not kill old Electron properly (zombie Electron process stuck around unless killed with
Force QuitThis PR switches to
https://www.npmjs.com/package/@magda/tree-killwhich includes a fix for macOS (see 2 commits = fix + release on https://github.com/magda-io/node-tree-kill/commits/magda/Screenshots
N/A
Testing
src/main/index.jsand save (e.g. add a blank lineDesktop
Additional context