Skip to content

Fix Disable Channel Links in Channel Sidenav Menu#9395

Open
ozrendev wants to merge 2 commits into
FreeTubeApp:developmentfrom
ozrendev:disable-links-channel-list
Open

Fix Disable Channel Links in Channel Sidenav Menu#9395
ozrendev wants to merge 2 commits into
FreeTubeApp:developmentfrom
ozrendev:disable-links-channel-list

Conversation

@ozrendev

@ozrendev ozrendev commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

relates to #8502

Description

These links were missed in the original PR, so this disables them as originally intended

Testing

Go to Settings -> Parental Control -> Enabled "Disable Channel Link on Videos"
Go to Channels sidenav item, see links are disabled for Channel thumbnail and name

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) July 10, 2026 06:01
@github-actions github-actions Bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jul 10, 2026
@PikachuEXE

PikachuEXE commented Jul 10, 2026

Copy link
Copy Markdown
Member

Should we also disable the icons on side bar? (PR disable channel links in Channel List
image

auto-merge was automatically disabled July 11, 2026 01:34

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) July 11, 2026 01:34
@ozrendev

ozrendev commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

Should we also disable the icons on side bar? (PR disable channel links in Channel List

Yes, good catch! Added that now

@efb4f5ff-1298-471a-8973-3d47447115dc

efb4f5ff-1298-471a-8973-3d47447115dc commented Jul 11, 2026

Copy link
Copy Markdown
Member

Umm i dont know if thats really necessary as there is already a setting to hide them. Making them non functional feels not logical to me but ofcourse my feeling could be wrong here

@PikachuEXE

PikachuEXE commented Jul 11, 2026

Copy link
Copy Markdown
Member

Well my reason would be the existing setting is under "distraction free" not parental control
And we should provide less surprise for users ("what? I need 2 settings to do what I want?
Now whether those sidebar icons should be displayed at all when the new setting is enabled is something else (I have no idea

@efb4f5ff-1298-471a-8973-3d47447115dc

efb4f5ff-1298-471a-8973-3d47447115dc commented Jul 11, 2026

Copy link
Copy Markdown
Member

I guess you're right. I didnt put myself in users shoes enough

efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc reviewed Jul 11, 2026
View reviewed changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the hover and click animation be disabled too here?

VirtualBoxVM_X4RSr56cFA.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc left review comments
@PikachuEXE PikachuEXE Awaiting requested review from PikachuEXE
@absidue absidue Awaiting requested review from absidue

At least 3 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

PR: waiting for review For PRs that are complete, tested, and ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ozrendev @PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc