Migrate the FtListVideo component to the composition API#9413
Open
absidue wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
PR: waiting for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
This pull request migrates the FtListVideo component to the composition API. Almost a 1:1 migration, did a few minor clean ups such as moving the blur thumbnails CSS to into a CSS class that gets toggled, instead of adding it inline in the template and moving
JSON.parse(hiddenChannels)into a computed.Testing
Please check videos in lists in various places in FreeTube (subscriptions, history, playlists, list and grid view, etc) and check that the functionality still works (adding and removing from a playlist, opening in an external player, copying the links in the 3 dots menu, etc).
Desktop