ci: install from the lockfile (uv sync --frozen), not pip install latest#114
Merged
Conversation
…ll latest CI ran 'pip install .[dev]', which ignores uv.lock and resolves dependencies to the latest release at run time -- non-deterministic, and different from what the image ships (the Dockerfile already builds with 'uv sync --frozen --no-dev'). Switch the ruff and unittest jobs to 'uv sync --frozen --extra dev' + 'uv run' so CI uses the locked versions. Mirrors the controller change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
CI (
ruff+unittest) now installs withuv sync --frozen --extra dev+uv run, instead ofpip install ".[dev]".Why
pip install ".[dev]"ignoresuv.lockand resolves to latest at run time — non-deterministic, and different from what the image ships (Dockerfilealready builds withuv sync --frozen --no-dev). A freshazure-mgmt-resource 26.0.0broke the controller's CI this way today; this repo dodged it only because it has no azure dep. Installing from the lock makes CI reproducible and matches the image. Mirrors freeshard-controller's CI change.🤖 Generated with Claude Code