fix(settings): drop dead subscription-status branches#25
Merged
Conversation
subscriptionState/subscribeButtonLabel matched 'suspended' and 'cancelled', which the controller never emits — SUSPENDED/CANCELLED webhooks both map to status 'grace'. Backend SubscriptionStatus is active/grace/ended/error. Reduce the reactivatable set to ['grace', 'ended']; no behaviour change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
subscriptionState/subscribeButtonLabelmatched'suspended'and'cancelled'status strings. The controller never emits those —BILLING.SUBSCRIPTION.SUSPENDED/CANCELLEDwebhooks both map to statusgrace(paypal.py). BackendSubscriptionStatusis onlyactive/grace/ended/error.Reduced the reactivatable set to
['grace', 'ended']. No behaviour change — purely removes the stale strings.Release note
Cosmetic; not worth its own web-terminal release + core bump. Let it ride the next web-terminal release (e.g. whenever the Case 2 resize fix lands), rather than spinning v13 just for this.
Surfaced by the PayPal verification audit. Tracks #265.
🤖 Generated with Claude Code