Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 5 minutes and 5 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a9c8cc81b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| uses: actions/checkout@v6 | ||
| with: | ||
| fetch-depth: 0 | ||
| ref: ${{ inputs.ref || github.ref }} |
There was a problem hiding this comment.
Pin build job to the tested commit SHA
In .github/workflows/release-nuget.yml, the new test-gate and existing build-pack-push jobs each run their own checkout from ${{ inputs.ref || github.ref }}; for workflow_dispatch this defaults to main, which is mutable. That means if main advances after test-gate passes but before build-pack-push starts, the package can be built/published from a different commit than the one that was tested, which breaks the intended hard gate. To keep the gate trustworthy, resolve and pass a specific commit SHA from test-gate to build-pack-push and checkout that SHA in the second job.
Useful? React with 👍 / 👎.
Motivation
Description
.github/workflows/pr-tests.ymlthat runs onpull_requestand executesdotnet test "${{ steps.solution.outputs.SOLUTION_PATH }}" -c Release --no-build --verbosity normalas a blocking gate.Release, runs tests with TRX logging (--logger "trx;LogFileName=test-results.trx") and uploads test results as artifacts for reviewer inspection..github/workflows/release-nuget.ymlto introduce a pre-publishtest-gatejob that performs the same restore/build/test sequence and madebuild-pack-pushdepend on it vianeeds: test-gateso pack/publish steps are blocked if tests fail.${{ steps.solution.outputs.SOLUTION_PATH }}.Testing
YAMLparser.PyYAMLin the environment..github/workflows/pr-tests.ymlwas added and.github/workflows/release-nuget.ymlwas updated to include thetest-gatejob andneeds: test-gatedependency.Codex Task