Pin NuGet release build to tested commit SHA#18
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe PR modifies the release-nuget GitHub Actions workflow to ensure both the test-gate and build-pack-push jobs use the same resolved commit SHA. A new resolve_sha step is added to compute the current commit SHA and export it as a job output, which is then referenced by the subsequent job for consistency. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Motivation
workflow_dispatchtherefinput defaults tomain, which can advance between jobs and allowbuild-pack-pushto run on a different commit than the one that passed tests. This breaks the intended hard gate.Description
resolved_shajob output ontest-gatepopulated by a newResolve checked out commit SHAstep that runsgit rev-parse HEADafter checkout.test-gateoutput intobuild-pack-pushby changing the second job's checkoutreftoneeds.test-gate.outputs.resolved_sha.Testing
git diff --checkwhich succeeded.git status --shortwhich showed the updated workflow file.git show --stat --oneline HEADto verify the change was committed successfully.Codex Task
Summary by CodeRabbit