Make AasBuilder fragment batches transactional with rollback#23
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3468e05
into
12-enable-incremental-submodel-composition-via-addsubmodel-at-any-stage-of-the-build-process
3 checks passed
Freezor
added a commit
that referenced
this pull request
Mar 27, 2026
#20) * Add staged submodel composition and validation (fragments) with tests (#19) * Update README for staged submodel composition and remove extra spec doc * Fix staged fragment idempotency and preserve internal submodel compatibility * 📝 Add docstrings to `12-enable-incremental-submodel-composition-via-addsubmodel-at-any-stage-of-the-build-process` (#21) Docstrings generation was requested by @Freezor. * #20 (comment) The following files were modified: * `FluentAAS/FluentAAS.Builder/AasBuilder.cs` * `FluentAAS/FluentAAS.Builder/IAasBuilder.cs` * `FluentAAS/FluentAAS.Builder/SubModel/SubmodelFragmentBuilder.cs` Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * 📝 CodeRabbit Chat: Add unit tests * Fix malformed XML docs in builder interfaces (#22) * FEAT Fix docs issue * Make submodel fragment application transactional in Build (#23) --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Submodelinstances, allowing partial mutations to persist when a fragment batch failed and causing duplicateSubmodelElements on subsequentBuild()calls.Build_WhenFragmentBatchFails_ShouldRollbackAppliedFragmentsBeforeRetryis satisfied.Description
AasBuilder.Build()with a call to a new helperApplySubmodelFragmentsTransactionally().ApplySubmodelFragmentsTransactionally()to pre-validate all target submodel ids, snapshot each touched submodel'sSubmodelElementspresence and count, apply all fragments, clear_submodelFragmentsonly on success, and roll back appended elements (including restoring anullcollection) on any exception.Testing
dotnet test FluentAAS/FluentAAS.Builder.Tests/FluentAAS.Builder.Tests.csproj --no-restore, but the execution environment does not havedotnetinstalled (dotnet: command not found), so automated tests could not be executed here.Build_WhenFragmentBatchFails_ShouldRollbackAppliedFragmentsBeforeRetryand related fragment tests.Codex Task