Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Inspired by the [OroCommerce Analytics/GTM Bundle](https://github.com/DivanteLtd

Requirements
-------------------
* OroCommerce 5.0.X
* OroCommerce 6.0.X

Installation and Usage
-------------------
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "OroCommerce Bundle to inject Tracking Code (eg LogRocket, Hotjar, FullStory, etc)",
"type": "project",
"require": {
"oro/commerce": "5.0.*"
"oro/commerce": "6.0.*"
},
"autoload": {
"psr-4": { "HackOro\\CustomerTrackingBundle\\": "./src/" }
Expand Down
4 changes: 2 additions & 2 deletions src/DependencyInjection/CompilerPass/TrackerPass.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class TrackerPass implements CompilerPassInterface
/**
* {@inheritdoc}
*/
public function process(ContainerBuilder $container)
public function process(ContainerBuilder $container): void
{
if (!$container->hasDefinition(self::REGISTRY_SERVICE)) {
return;
Expand All @@ -44,4 +44,4 @@ public function process(ContainerBuilder $container)
$registryDefinition->addMethodCall('addTracker', [new Reference($tracker)]);
}
}
}
}
11 changes: 2 additions & 9 deletions src/DependencyInjection/Configuration.php
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,8 @@ class Configuration implements ConfigurationInterface

/**
* Generates the configuration tree builder.
*
* @return TreeBuilder The tree builder
*/
public function getConfigTreeBuilder()
public function getConfigTreeBuilder(): TreeBuilder
{
$treeBuilder = new TreeBuilder(HackOroCustomerTrackingExtension::ALIAS);

Expand All @@ -59,12 +57,7 @@ public function getConfigTreeBuilder()
return $treeBuilder;
}


/**
* @param string $key
* @return string
*/
public static function getConfigKeyByName($key)
public static function getConfigKeyByName(string $key): string
{
return implode(ConfigManager::SECTION_MODEL_SEPARATOR, [HackOroCustomerTrackingExtension::ALIAS, $key]);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class HackOroCustomerTrackingExtension extends Extension
/**
* @inheritdoc
*/
public function load(array $configs, ContainerBuilder $container)
public function load(array $configs, ContainerBuilder $container): void
{
$configuration = new Configuration();
$config = $this->processConfiguration($configuration, $configs);
Expand Down
2 changes: 1 addition & 1 deletion src/HackOroCustomerTrackingBundle.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class HackOroCustomerTrackingBundle extends Bundle
/**
* {@inheritdoc}
*/
public function build(ContainerBuilder $container)
public function build(ContainerBuilder $container): void
{
parent::build($container);

Expand Down
9 changes: 2 additions & 7 deletions src/Layout/DataProvider/CustomerTrackingDataProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,14 @@

class CustomerTrackingDataProvider
{
/** @var TrackerRegistry */
private $trackerRegistry;
private TrackerRegistry $trackerRegistry;

public function __construct(TrackerRegistry $trackerRegistry)
{
$this->trackerRegistry = $trackerRegistry;
}

/**
* @param string $name
* @return AbstractTracker|null
*/
public function getTracker(string $name)
public function getTracker(string $name): ?AbstractTracker
{
return $this->trackerRegistry->getTracker($name);
}
Expand Down
10 changes: 2 additions & 8 deletions src/Tracker/AbstractTracker.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@

abstract class AbstractTracker
{
/** @var ConfigManager */
protected $configManager;
protected ConfigManager $configManager;

public function __construct(ConfigManager $configManager)
{
Expand All @@ -24,12 +23,7 @@ public function __construct(ConfigManager $configManager)

abstract public function getName() : string;

/**
* @param string $name
* @param bool $default
* @return mixed
*/
public function getConfigValue(string $name, $default = false)
public function getConfigValue(string $name, bool $default = false): mixed
{
return $this->configManager->get(Configuration::getConfigKeyByName($name), $default);
}
Expand Down
15 changes: 0 additions & 15 deletions src/Tracker/FullStoryTracker.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,41 +28,26 @@ public function getName(): string
return self::NAME;
}

/**
* @return bool
*/
public function isEnabled(): bool
{
return (bool) $this->getConfigValue(Configuration::FULLSTORY_IS_ENABLED);
}

/**
* @return string
*/
public function getOrg(): ?string
{
return $this->getConfigValue(Configuration::FULLSTORY_ORG);
}

/**
* @return bool
*/
public function getDebugEnabled(): bool
{
return (bool) $this->getConfigValue(Configuration::FULLSTORY_DEBUG_ENABLED);
}

/**
* @return string
*/
public function getNamespace(): ?string
{
return $this->getConfigValue(Configuration::FULLSTORY_NAMESPACE) ?? self::DEFAULT_NAMESPACE;
}

/**
* @return string
*/
public function getHost(): ?string
{
return self::HOST;
Expand Down
6 changes: 0 additions & 6 deletions src/Tracker/HotjarTracker.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,11 @@ public function getName(): string
return self::NAME;
}

/**
* @return bool
*/
public function isEnabled(): bool
{
return (bool) $this->getConfigValue(Configuration::HOTJAR_IS_ENABLED);
}

/**
* @return string
*/
public function getSiteId(): ?string
{
return $this->getConfigValue(Configuration::HOTJAR_SITE_ID);
Expand Down
4 changes: 0 additions & 4 deletions src/Tracker/LogRocketTracker.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ public function getName(): string

/**
* Is LogRocket enabled?
*
* @return bool
*/
public function isEnabled(): bool
{
Expand All @@ -32,8 +30,6 @@ public function isEnabled(): bool

/**
* What is the LogRocket APP ID?
*
* @return string
*/
public function getAppId(): ?string
{
Expand Down
12 changes: 4 additions & 8 deletions src/Tracker/TrackerRegistry.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,12 @@ class TrackerRegistry
/**
* @var AbstractTracker[]
*/
protected $trackers = [];
protected array $trackers = [];

/**
* Add tracker to the registry
*
* @param AbstractTracker $tracker
*/
public function addTracker(AbstractTracker $tracker)
public function addTracker(AbstractTracker $tracker): void
{
if (array_key_exists($tracker->getName(), $this->trackers)) {
throw new LogicException(
Expand All @@ -37,19 +35,17 @@ public function addTracker(AbstractTracker $tracker)
/**
* @return AbstractTracker[]
*/
public function getTrackers()
public function getTrackers(): array
{
return $this->trackers;
}

/**
* Get tracker by name
*
* @param string $name
* @return AbstractTracker
* @throws LogicException Throw exception when tracker with specified name not found
*/
public function getTracker($name)
public function getTracker(string $name): AbstractTracker
{
if (!array_key_exists($name, $this->trackers)) {
throw new LogicException(
Expand Down