feat: configurable queue monitoring for QueueChecker (#269) - #448
Merged
shyim merged 6 commits intoJul 26, 2026
Merged
Conversation
…re#269) Failed messenger transports (async_failed, …) were treated like live queues and caused false positives in System Status / frosh:monitor. - Exclude queue names containing "failed" by default (toggleable) - Optional allowlist of queues to monitor - Optional per-queue grace times (queue:minutes) - Fix age calculation (was effectively ~2× the configured grace) - Surface oldest queue name in the status current value - Unit tests (9) covering filters, grace overrides, and age math
Contributor
Greptile SummaryUpdates queue monitoring to evaluate each queue independently against configurable grace periods, optionally exclude failed queues, support an allowlist, and report the worst overdue queue.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains in the fix associated with the previous review thread. Important Files Changed
Reviews (5): Last reviewed commit: "fix: satisfy phpstan in QueueChecker wor..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Replace hand-built SQL with Connection::createQueryBuilder(), matching TaskChecker and keeping named parameters / ArrayParameterType for the queue allowlist.
Keep mock-based QueueCheckerUnitTest for config/age edge cases, and put back IntegrationTestCase coverage (real messenger_messages + QueryBuilder) including failed-queue exclusion, allowlist, and per-queue grace.
Contributor
|
Hey 👋, I have created for you a Shopware installation with the current changes made here. You can access the Shop here: https://vcd25vg-d3q7en6rd4dpu.zrh2.namespaced.app The URL is only for FriendsOfShopware members. |
Addresses Greptile P1 on FriendsOfShopware#448: a global oldest-message LIMIT 1 could hide a newer message that already exceeded a shorter per-queue grace. Fetch MIN(available_at) per queue_name and pick the worst offender (furthest past its own grace, else oldest healthy age).
booleanAnd.rightAlwaysTrue after the overdue/healthy branch; simplify comparison so shopware-cli extension validate --full is clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #269.
Failed messenger queues (e.g.
async_failed) that are drained manually were counted byQueueChecker, which led to false positives in System Status andfrosh:monitor.Changes
truequeue_name LIKE '%failed%'async:15, low_priority:60overrides15Also fixes age math: the previous formula effectively required
age > 2 × gracebefore warning. It now uses the real pending age in minutes.Status
currentnow includes the queue name, e.g.42 mins (async).Config UI
Extension config → Monitoring card (DE labels included).
Tests
Unit tests with mocked
Connection/SystemConfigService(no kernel).Test plan
async_failed→ no warning with default config; warning when “Exclude failed queues” is off