fix: clarify EOL findings track official support only (#445) - #450
Merged
shyim merged 1 commit intoJul 29, 2026
Merged
Conversation
…are#445) The security center reported e.g. MySQL 8.0 on Ubuntu 24.04 as plain "end-of-life" although the distribution still backports security fixes, which read like a false positive. Severity stays critical per the issue discussion; the messages now state that official support ended.
Contributor
Greptile SummaryClarifies that critical and approaching-EOL findings refer to official support.
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The changed strings are display-only, consumers do not branch on their exact values, custom recommendations remain intact, and the new tests cover all severity paths.
|
| Filename | Overview |
|---|---|
| src/Components/Security/Checker/EolFindingFactory.php | Updates display-only EOL wording and default recommendations without changing severity or detection behavior. |
| tests/Components/Security/Checker/EolFindingFactoryTest.php | Adds comprehensive tests for unknown, critical, high, medium, and supported EOL states, including custom hints. |
Reviews (1): Last reviewed commit: "fix: clarify EOL findings track official..." | Re-trigger Greptile
shyim
approved these changes
Jul 29, 2026
Member
|
Thank you here also. I thought first it was your issue, but not. Thanks really! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #445.
On distribution-packaged runtimes the security center reports for example MySQL 8.0 as "end-of-life since 2026-04-30" although Ubuntu 24.04 keeps backporting security fixes. The finding itself is correct, Oracle has ended support. But the message does not say whose support ended, so it reads like a false positive.
Following the direction in the issue, the severity stays red and only the messages change:
8.0.43 (official end-of-life since 2026-04-30), and the default recommendation becomesUpgrade to a release that still receives official security fixesofficialqualifierThe current-version line changes for all three endoflife.date-backed checks (PHP, MySQL/MariaDB, Symfony), not only the distribution-packaged ones, and only in the critical and high states. The new default recommendation lands on PHP and MySQL/MariaDB, the Symfony checker keeps its custom hint.
I added a unit test covering all severity branches of EolFindingFactory and verified that the message assertions fail without the change. The security-center screenshot in the README still shows the previous wording. I can re-shoot it if you want that in this PR.