Skip to content

fix: clarify EOL findings track official support only (#445) - #450

Merged
shyim merged 1 commit into
FriendsOfShopware:mainfrom
pavel-rossinsky:fix/eol-official-support-message
Jul 29, 2026
Merged

fix: clarify EOL findings track official support only (#445)#450
shyim merged 1 commit into
FriendsOfShopware:mainfrom
pavel-rossinsky:fix/eol-official-support-message

Conversation

@pavel-rossinsky

Copy link
Copy Markdown
Contributor

Fixes #445.

On distribution-packaged runtimes the security center reports for example MySQL 8.0 as "end-of-life since 2026-04-30" although Ubuntu 24.04 keeps backporting security fixes. The finding itself is correct, Oracle has ended support. But the message does not say whose support ended, so it reads like a false positive.

Following the direction in the issue, the severity stays red and only the messages change:

  • critical: 8.0.43 (official end-of-life since 2026-04-30), and the default recommendation becomes Upgrade to a release that still receives official security fixes
  • high: the approaching-EOL line and its default recommendation get the same official qualifier

The current-version line changes for all three endoflife.date-backed checks (PHP, MySQL/MariaDB, Symfony), not only the distribution-packaged ones, and only in the critical and high states. The new default recommendation lands on PHP and MySQL/MariaDB, the Symfony checker keeps its custom hint.

I added a unit test covering all severity branches of EolFindingFactory and verified that the message assertions fail without the change. The security-center screenshot in the README still shows the previous wording. I can re-shoot it if you want that in this PR.

…are#445)

The security center reported e.g. MySQL 8.0 on Ubuntu 24.04 as plain "end-of-life" although the distribution still backports security fixes, which read like a false positive. Severity stays critical per the issue discussion; the messages now state that official support ended.
@greptile-apps

greptile-apps Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Clarifies that critical and approaching-EOL findings refer to official support.

  • Adds the “official” qualifier to critical and high EOL status messages.
  • Updates default upgrade recommendations while preserving custom hints.
  • Adds unit coverage for every EOL severity branch and custom recommendations.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The changed strings are display-only, consumers do not branch on their exact values, custom recommendations remain intact, and the new tests cover all severity paths.

Important Files Changed

Filename Overview
src/Components/Security/Checker/EolFindingFactory.php Updates display-only EOL wording and default recommendations without changing severity or detection behavior.
tests/Components/Security/Checker/EolFindingFactoryTest.php Adds comprehensive tests for unknown, critical, high, medium, and supported EOL states, including custom hints.

Reviews (1): Last reviewed commit: "fix: clarify EOL findings track official..." | Re-trigger Greptile

@shyim
shyim merged commit 9b1064e into FriendsOfShopware:main Jul 29, 2026
9 checks passed
@pavel-rossinsky
pavel-rossinsky deleted the fix/eol-official-support-message branch July 29, 2026 10:43
@shyim

shyim commented Jul 29, 2026

Copy link
Copy Markdown
Member

Thank you here also. I thought first it was your issue, but not. Thanks really!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False positives for runtime components on LTS distributions

2 participants