Skip to content

fix: no longer report actively supported releases as end of active support (#451) - #452

Merged
shyim merged 1 commit into
FriendsOfShopware:mainfrom
pavel-rossinsky:fix/endoflife-boolean-support
Jul 29, 2026
Merged

fix: no longer report actively supported releases as end of active support (#451)#452
shyim merged 1 commit into
FriendsOfShopware:mainfrom
pavel-rossinsky:fix/endoflife-boolean-support

Conversation

@pavel-rossinsky

Copy link
Copy Markdown
Contributor

Fixes #451.

The v0 API's boolean support means active support exists when true (schema: "Whether this release cycle has active support"). normalizeEntry() mapped support === true to supportEnded = true and let support === false fall through to false, so both boolean cases were inverted: the security center reported the supported MySQL 9.7 as 9.7.2 (active support ended, security fixes only), and a cycle whose support really ended would report as supported. Date-string values were handled correctly and are unchanged.

The fix maps support === false to supportEnded = true; true and absent stay not ended.

I added the first tests for EndOfLifeService, through the public getCycle() with a mocked HTTP client: both boolean cases (red without the fix), both date directions, an unparseable date, the absent field, an API error and the unknown cycle.

…pport (FriendsOfShopware#451)

The v0 API's boolean support means active support exists when true. The inverted mapping reported supported cycles as "active support ended" and would hide cycles whose support really ended.
@greptile-apps

greptile-apps Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR corrects boolean active-support normalization and adds coverage for boolean, date, missing, malformed, API-error, and unknown-cycle responses.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The boolean mapping now matches the documented API contract, downstream support-status semantics remain consistent, and the new tests cover the corrected cases and existing fallback behavior.

Important Files Changed

Filename Overview
src/Components/Security/EndOfLifeService.php Correctly maps a false API support flag to an ended active-support period while preserving date handling.
tests/Components/Security/EndOfLifeServiceTest.php Adds compatible public-API tests covering support normalization and key failure paths.

Reviews (1): Last reviewed commit: "fix: no longer report actively supported..." | Re-trigger Greptile

@shyim

shyim commented Jul 29, 2026

Copy link
Copy Markdown
Member

Thank you!

@shyim
shyim merged commit 86e4cc2 into FriendsOfShopware:main Jul 29, 2026
9 checks passed
@pavel-rossinsky
pavel-rossinsky deleted the fix/endoflife-boolean-support branch July 29, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Security center reports supported MySQL 9.7 as "active support ended" (boolean support field read inverted)

2 participants