fix: no longer report actively supported releases as end of active support (#451) - #452
Merged
shyim merged 1 commit intoJul 29, 2026
Conversation
…pport (FriendsOfShopware#451) The v0 API's boolean support means active support exists when true. The inverted mapping reported supported cycles as "active support ended" and would hide cycles whose support really ended.
Contributor
Greptile SummaryThe PR corrects boolean active-support normalization and adds coverage for boolean, date, missing, malformed, API-error, and unknown-cycle responses. Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The boolean mapping now matches the documented API contract, downstream support-status semantics remain consistent, and the new tests cover the corrected cases and existing fallback behavior.
|
| Filename | Overview |
|---|---|
| src/Components/Security/EndOfLifeService.php | Correctly maps a false API support flag to an ended active-support period while preserving date handling. |
| tests/Components/Security/EndOfLifeServiceTest.php | Adds compatible public-API tests covering support normalization and key failure paths. |
Reviews (1): Last reviewed commit: "fix: no longer report actively supported..." | Re-trigger Greptile
shyim
approved these changes
Jul 29, 2026
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #451.
The v0 API's boolean
supportmeans active support exists whentrue(schema: "Whether this release cycle has active support").normalizeEntry()mappedsupport === truetosupportEnded = trueand letsupport === falsefall through tofalse, so both boolean cases were inverted: the security center reported the supported MySQL 9.7 as9.7.2 (active support ended, security fixes only), and a cycle whose support really ended would report as supported. Date-string values were handled correctly and are unchanged.The fix maps
support === falsetosupportEnded = true;trueand absent stay not ended.I added the first tests for
EndOfLifeService, through the publicgetCycle()with a mocked HTTP client: both boolean cases (red without the fix), both date directions, an unparseable date, the absent field, an API error and the unknown cycle.