Skip to content

Add ionCube Loader performance warning - #453

Merged
shyim merged 1 commit into
mainfrom
copilot/add-ioncube-performance-checker
Jul 29, 2026
Merged

Add ionCube Loader performance warning#453
shyim merged 1 commit into
mainfrom
copilot/add-ioncube-performance-checker

Conversation

Copilot AI commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

ionCube Loader can significantly degrade Shopware performance when enabled. Add a performance recommendation so operators can identify and remove it.

  • Performance checker
    • Auto-register IonCubeLoaderChecker with the existing performance-checker pipeline.
    • Emit a warning when ionCube Loader is installed.
if ($extensionLoaded('ionCube Loader')) {
    $collection->add(SettingsResult::warning(
        'ioncube-loader',
        'ionCube Loader can drastically decrease performance',
        'enabled',
        'disabled',
    ));
}
  • Coverage
    • Add focused tests for both installed and absent Loader states.

@shyim
shyim marked this pull request as ready for review July 29, 2026 12:56
@greptile-apps

greptile-apps Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds an automatically registered performance checker that warns when ionCube Loader is enabled.

  • Detects the extension through extension_loaded.
  • Reports the enabled and recommended disabled states.
  • Tests both installed and absent extension states.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The checker follows the existing autoconfiguration pipeline, constructs the warning according to the established result contract, and covers both detection branches.

Important Files Changed

Filename Overview
src/Components/Health/Checker/PerformanceChecker/IonCubeLoaderChecker.php Adds a correctly autoconfigured checker that emits a performance warning when ionCube Loader is detected.
tests/Components/Health/Checker/PerformanceChecker/IonCubeLoaderCheckerTest.php Covers both detection outcomes and verifies the complete warning result.

Reviews (1): Last reviewed commit: "Add ionCube performance checker" | Re-trigger Greptile

@shyim
shyim merged commit f734c30 into main Jul 29, 2026
9 checks passed
@shyim
shyim deleted the copilot/add-ioncube-performance-checker branch July 29, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants