fix: disable otelpgx pool.acquire spans in Datadog - #794
Merged
Conversation
Drop high-volume, low-signal acquire tracing while keeping query/exec/prepare spans (including sqlc SpanNameFunc naming). Co-authored-by: Soner <github@shyim.de>
shyim
marked this pull request as ready for review
August 12, 2026 07:00
Contributor
Greptile SummaryThe PR disables otelpgx connection-pool acquire spans to reduce low-signal Datadog telemetry while retaining existing database operation tracing.
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The pinned otelpgx version supports the new option, and its scoped behavior suppresses pool-acquire tracing without changing pool operation or the existing query span instrumentation.
|
| Filename | Overview |
|---|---|
| api/internal/database/db.go | Adds the supported acquire-tracer opt-out to the shared pool tracer configuration without affecting connection behavior or database-operation spans. |
Reviews (1): Last reviewed commit: "fix: disable otelpgx pool.acquire spans ..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WithDisableAcquireTracer()when constructing the tracer inNewPool.SpanNameFuncnaming from fix: use sqlc query names for otelpgx/Datadog DB span resources #791.Why
Prod emits high volumes of low-signal
pool.acquire/client.requestspans that add little monitoring value in Datadog.Test plan
mise run lintmise run testpool.acquire/ related client.request noise drops while named DB query spans remain.