Skip to content

[TASK] Use ComposerJsonManipulator from SimonSchaufi #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonschaufi merged 1 commit into from
Jul 11, 2026
Merged

[TASK] Use ComposerJsonManipulator from SimonSchaufi #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@
"ext-xml": "*",
"composer-plugin-api": "^2.0",
"ergebnis/json-printer": "^3.5",
"eta-orionis/composer-json-manipulator": "^1.0.1",
"helmich/typo3-typoscript-parser": "^2.8.0",
"league/flysystem": "^2.0 || ^3.0",
"league/flysystem-memory": "^2.0 || ^3.0",
"nette/utils": "^4.0",
"ondram/ci-detector": "^4.2",
"phpstan/phpstan": "^2.0.0",
"sebastian/diff": "^4.0 || ^5.0 || ^6.0 || ^7.0 || ^8.0 || ^9.0",
"simonschaufi/composer-json-manipulator": "^1.0",
"simonschaufi/pretty-xml": "^3.0.0",
"symfony/config": "^5.4 || ^6.4 || ^7.0 || ^8.0",
"symfony/console": "^5.4 || ^6.4 || ^7.0 || ^8.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/fractor-composer-json/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
"a9f/fractor-doc-generator": "^1.0",
"a9f/fractor-extension-installer": "^1.0",
"ergebnis/json-printer": "^3.5",
"eta-orionis/composer-json-manipulator": "^1.0.1",
"nette/utils": "^4.0",
"simonschaufi/composer-json-manipulator": "^1.0",
"symplify/rule-doc-generator-contracts": "^11.2",
"webmozart/assert": "^1.11 || ^2.0"
},
Expand Down
6 changes: 3 additions & 3 deletions ...er-json/rules-tests/AddPackageToRequireComposerJsonFractor/Fixtures/composer.json.fixture
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@
}
-----
{
"require": {
"vendor1/package3": "^3.0"
},
"require-dev": {
"vendor1/package1": "^1.0",
"vendor1/package2": "^2.0"
},
"require": {
"vendor1/package3": "^3.0"
}
}
6 changes: 3 additions & 3 deletions packages/fractor-composer-json/src/ComposerJsonFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
namespace a9f\FractorComposerJson;

use a9f\Fractor\Application\ValueObject\File;
use a9f\FractorComposerJson\ValueObject\EtaOrionisComposerJson;
use a9f\FractorComposerJson\ValueObject\ComposerJsonValueObject;

final class ComposerJsonFactory
{
public function createFromFile(File $file): EtaOrionisComposerJson
public function createFromFile(File $file): ComposerJsonValueObject
{
return EtaOrionisComposerJson::fromFile($file);
return ComposerJsonValueObject::fromFile($file);
}
}
9 changes: 5 additions & 4 deletions ...rc/ValueObject/EtaOrionisComposerJson.php → ...c/ValueObject/ComposerJsonValueObject.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,19 @@
namespace a9f\FractorComposerJson\ValueObject;

use a9f\Fractor\Application\ValueObject\File;
use a9f\FractorComposerJson\Contract\ComposerJson;
use a9f\FractorComposerJson\Contract\ComposerJson as ComposerJsonInterface;
use SimonSchaufi\ComposerJsonManipulator\ComposerJson;

final readonly class EtaOrionisComposerJson implements ComposerJson
final readonly class ComposerJsonValueObject implements ComposerJsonInterface
{
public function __construct(
private \EtaOrionis\ComposerJsonManipulator\ComposerJson $composerJson
private ComposerJson $composerJson
) {
}

public static function fromFile(File $file): self
{
return new self(\EtaOrionis\ComposerJsonManipulator\ComposerJson::fromFile($file->getFilePath()));
return new self(ComposerJson::fromFile($file->getFilePath()));
}

public function getJsonArray(): array
Expand Down