Rust Artifact Discovery#34
Merged
Merged
Conversation
📝 WalkthroughWalkthroughThis PR implements a complete artifact detection system for the ChangesArtifact Detection and Scan Command
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
crates/dustfril-core/src/detector/cargo_project.rs (1)
3-3: 💤 Low valueDoc comment doesn't match function behavior.
The comment mentions "artifact scanning" but this function only performs Cargo project detection. Consider updating to:
/// Checks whether a directory is a Cargo project.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@crates/dustfril-core/src/detector/cargo_project.rs` at line 3, Update the top-level/doc comment that currently reads "Cargo project detection and artifact scanning" to accurately reflect the function's behavior—replace it with a precise description such as "Checks whether a directory is a Cargo project." Locate the comment in crates/dustfril-core/src/detector/cargo_project.rs (the module housing the Cargo detection logic, e.g., the function that performs project detection) and edit the doc comment to match the actual behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/dustfril-core/src/detector/git.rs`:
- Around line 15-17: The existence check for the detected git artifact is
insufficient—update the conditional that currently uses git_path.exists() to
also verify it's a directory (e.g., change to git_path.exists() &&
git_path.is_dir()) so that a regular file named "git" won't be treated as the
git directory; locate the check around the git_path variable in the
detector/git.rs detection function and return None unless both conditions are
true.
In `@crates/dustfril-core/src/detector/registry.rs`:
- Around line 15-17: The existence check for the registry artifact is too
permissive—update the conditional that currently uses registry_path.exists()
(the branch that returns None when not found) to also require
registry_path.is_dir(), i.e., only treat the path as valid if it both exists and
is a directory; modify the conditional around registry_path to use &&
registry_path.is_dir() so files named "registry" aren't misidentified as the
registry directory.
In `@crates/dustfril-core/src/detector/target.rs`:
- Around line 8-10: The existence check for the detected artifact should ensure
it's a directory, not just any filesystem entry: update the conditional that
currently uses target_path.exists() (in detector/target.rs where target_path is
checked) to also require target_path.is_dir() (e.g., change the guard to if
!target_path.exists() || !target_path.is_dir() { return None; } or equivalent)
so only a real "target" directory is accepted.
---
Nitpick comments:
In `@crates/dustfril-core/src/detector/cargo_project.rs`:
- Line 3: Update the top-level/doc comment that currently reads "Cargo project
detection and artifact scanning" to accurately reflect the function's
behavior—replace it with a precise description such as "Checks whether a
directory is a Cargo project." Locate the comment in
crates/dustfril-core/src/detector/cargo_project.rs (the module housing the Cargo
detection logic, e.g., the function that performs project detection) and edit
the doc comment to match the actual behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: eb730eba-7af1-4b6a-b2ab-37fee3f5a4cd
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (23)
.github/ISSUE_TEMPLATE/EPIC.md.github/ISSUE_TEMPLATE/FEATURE_TESK.md.github/ISSUE_TEMPLATE/TASK.mdapps/dustfril-cli/Cargo.tomlapps/dustfril-cli/src/cli.rsapps/dustfril-cli/src/commands/analyze.rsapps/dustfril-cli/src/commands/clean.rsapps/dustfril-cli/src/commands/mod.rsapps/dustfril-cli/src/commands/scan.rsapps/dustfril-cli/src/main.rscrates/dustfril-core/Cargo.tomlcrates/dustfril-core/src/detector/cargo_project.rscrates/dustfril-core/src/detector/git.rscrates/dustfril-core/src/detector/mod.rscrates/dustfril-core/src/detector/registry.rscrates/dustfril-core/src/detector/scan.rscrates/dustfril-core/src/detector/target.rscrates/dustfril-core/src/detector/tests.rscrates/dustfril-core/src/lib.rscrates/dustfril-core/src/models/artifact_location.rscrates/dustfril-core/src/models/artifact_type.rscrates/dustfril-core/src/models/mod.rscrates/dustfril-core/src/models/scan_result.rs
💤 Files with no reviewable changes (4)
- crates/dustfril-core/src/lib.rs
- .github/ISSUE_TEMPLATE/TASK.md
- .github/ISSUE_TEMPLATE/FEATURE_TESK.md
- .github/ISSUE_TEMPLATE/EPIC.md
Comment on lines
+15
to
+17
| if !git_path.exists() { | ||
| return None; | ||
| } |
There was a problem hiding this comment.
Verify that the detected path is a directory.
The current check only verifies existence. A file named "git" in ~/.cargo would be incorrectly identified as an artifact. Add && git_path.is_dir() to ensure you're detecting the git directory.
🛡️ Proposed fix
- if !git_path.exists() {
+ if !git_path.exists() || !git_path.is_dir() {
return None;
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| if !git_path.exists() { | |
| return None; | |
| } | |
| if !git_path.exists() || !git_path.is_dir() { | |
| return None; | |
| } |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@crates/dustfril-core/src/detector/git.rs` around lines 15 - 17, The existence
check for the detected git artifact is insufficient—update the conditional that
currently uses git_path.exists() to also verify it's a directory (e.g., change
to git_path.exists() && git_path.is_dir()) so that a regular file named "git"
won't be treated as the git directory; locate the check around the git_path
variable in the detector/git.rs detection function and return None unless both
conditions are true.
Comment on lines
+15
to
+17
| if !registry_path.exists() { | ||
| return None; | ||
| } |
There was a problem hiding this comment.
Verify that the detected path is a directory.
The current check only verifies existence. A file named "registry" in ~/.cargo would be incorrectly identified as an artifact. Add && registry_path.is_dir() to ensure you're detecting the registry directory.
🛡️ Proposed fix
- if !registry_path.exists() {
+ if !registry_path.exists() || !registry_path.is_dir() {
return None;
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| if !registry_path.exists() { | |
| return None; | |
| } | |
| if !registry_path.exists() || !registry_path.is_dir() { | |
| return None; | |
| } |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@crates/dustfril-core/src/detector/registry.rs` around lines 15 - 17, The
existence check for the registry artifact is too permissive—update the
conditional that currently uses registry_path.exists() (the branch that returns
None when not found) to also require registry_path.is_dir(), i.e., only treat
the path as valid if it both exists and is a directory; modify the conditional
around registry_path to use && registry_path.is_dir() so files named "registry"
aren't misidentified as the registry directory.
Comment on lines
+8
to
+10
| if !target_path.exists() { | ||
| return None; | ||
| } |
There was a problem hiding this comment.
Verify that the detected path is a directory.
The current check only verifies existence, but a file named "target" would be incorrectly identified as an artifact. Add && target_path.is_dir() to ensure you're detecting the target directory, not a file.
🛡️ Proposed fix
- if !target_path.exists() {
+ if !target_path.exists() || !target_path.is_dir() {
return None;
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| if !target_path.exists() { | |
| return None; | |
| } | |
| if !target_path.exists() || !target_path.is_dir() { | |
| return None; | |
| } |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@crates/dustfril-core/src/detector/target.rs` around lines 8 - 10, The
existence check for the detected artifact should ensure it's a directory, not
just any filesystem entry: update the conditional that currently uses
target_path.exists() (in detector/target.rs where target_path is checked) to
also require target_path.is_dir() (e.g., change the guard to if
!target_path.exists() || !target_path.is_dir() { return None; } or equivalent)
so only a real "target" directory is accepted.
This was referenced Jun 1, 2026
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Completed "detector v0.1.0" from "crates/dustfril-core".
"crates/dustfril-core"의 "detecter v0.1.0"를 완성했습니다.
Expected Behavior
Run "cargo run -p dustfril-cli -- scan" in the project route to get the output.
프로젝트 루트에서 "cargo run -p dustfril-cli -- scan"을 실행하면, 출력 결과를 얻을 수 있습니다.
Additional Notes
Closes #3
Closes #8
Closes #9
Closes #10
Closes #11
Closes #12
Closes #13
Closes #14
Closes #32
Closes #33
Checklist
Required
Functional Validation
Documentation
Safety
Summary by CodeRabbit
New Features
dfrcommand-line tool to identify Rust project artifacts via the scan commandTests