Skip to content

Fixes to make the CI a bit happier #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Friz64 merged 4 commits into from
May 3, 2026
Merged

Fixes to make the CI a bit happier #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ebc782e
make rewrite compile without std
BitSyndicate1 May 3, 2026
b747f2c
fix rustfmt error
BitSyndicate1 May 3, 2026
dcfed27
fix dependence on /home/friz64/source for analysis test
BitSyndicate1 May 3, 2026
c0f1366
run cargo fmt
BitSyndicate1 May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions analysis/src/xml.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -965,11 +965,7 @@ mod tests {
);

let waff3 = Registry::parse(xml_input, LibraryName::Vk, "vulkan");
std::fs::write(
"/home/friz64/source/ash/target/waff3",
format!("{waff3:#?}"),
)
.unwrap();
std::fs::write("../target/waff3", format!("{waff3:#?}")).unwrap();
}

#[test]
Expand All @@ -982,10 +978,6 @@ mod tests {
);

let waff3 = Registry::parse(xml_input, LibraryName::Video, "vulkan");
std::fs::write(
"/home/friz64/source/ash/target/waff3video",
format!("{waff3:#?}"),
)
.unwrap();
std::fs::write("../target/waff3video", format!("{waff3:#?}")).unwrap();
Copy link
Copy Markdown
Owner

@Friz64 Friz64 May 3, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh, this is just some stupid debugging code I've yet to find a better location for

Copy link
Copy Markdown
Author

@BitSyndicate1 BitSyndicate1 May 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could probably write an integration test and then use the CARGO_TARGET_TMPDIR env!() variable

CARGO_TARGET_TMPDIR — Only set when building integration test or benchmark code. This is a path to a directory inside the target directory where integration tests or benchmarks are free to put any data needed by the tests/benches. Cargo initially creates this directory but doesn’t manage its content in any way, this is the responsibility of the test code.

https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-crates

}
}
3 changes: 2 additions & 1 deletion ash-rewrite/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@ mod generated;
/// Type definitions for platform-specific external types
pub mod platform_types;

use alloc::vec::Vec;
use core::{mem, ptr};
pub use generated::*;
use std::{mem, ptr};

#[allow(clippy::wrong_self_convention)]
pub trait Handle: Sized {
Expand Down
2 changes: 1 addition & 1 deletion generator-rewrite/src/item/bitmask.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ impl Code for BitMask {
impl #name {
#values

pub const fn empty() -> Self {
pub const fn empty() -> Self {
Self(0)
}

Expand Down
Loading