Fix #3, bank transfer reference incorrect when editing#4
Open
cambell-prince wants to merge 2 commits intoFrontAccountingERP:unstablefrom
Open
Fix #3, bank transfer reference incorrect when editing#4cambell-prince wants to merge 2 commits intoFrontAccountingERP:unstablefrom
cambell-prince wants to merge 2 commits intoFrontAccountingERP:unstablefrom
Conversation
Owner
|
This patch removes reference templates handling for all payment/deposit transactions, even for new ones. While it can be disputable for edited transaction, it is not acceptable for new one. But also for transaction edition it introduces problems. |
Contributor
Author
|
This is now a partial fix, and I've also applied a fix in the context of PR #8, in this commit. Still this PR is closer to what is required and should do no harm, even with out PR #8. |
ksfraser
referenced
this pull request
in ksfraser/FA
Dec 3, 2025
- Created Inventory ABC Analysis Report service class - Implements Pareto principle (80/20 rule) for inventory optimization - 22 comprehensive test cases (TDD approach) - Added hooks for FA integration and dashboard widget - Complete README with usage examples and strategies - Committed and pushed to Reports submodule (22c5d68) Implementation status: Report #1: Cash Flow Statement (complete) Report #2: ABC Analysis (complete) Report #3: Supplier Performance Dashboard (next) Report #4: Product Profitability Analysis Report FrontAccountingERP#5: Working Capital Analysis Report FrontAccountingERP#6: Sales Analysis Dashboard
ksfraser
referenced
this pull request
in ksfraser/FA
Dec 3, 2025
…6) - Created Supplier Performance Dashboard service class (595 lines) - 19 comprehensive test cases covering all metrics (all passing) - Hooks for FA integration with dashboard widget (276 lines) - Complete README with use cases and best practices (465 lines) - Committed and pushed to Reports submodule (b6412d7) Implementation status: Report #1: Cash Flow Statement (complete) Report #2: Inventory ABC Analysis (complete) Report #3: Supplier Performance Dashboard (complete) Report #4: Product Profitability Analysis (next) Report FrontAccountingERP#5: Working Capital Analysis Report FrontAccountingERP#6: Sales Analysis Dashboard Total lines added: 1,336 (service + tests + hooks + docs)
ksfraser
referenced
this pull request
in ksfraser/FA
Dec 3, 2025
- 22 comprehensive test cases covering all profitability calculations - Tests for gross profit, contribution margin, per-unit metrics - Cost breakdown validation (material/labor/overhead) - Top/bottom 10 product identification tests - Pricing recommendation and break-even analysis tests - Category-based and trend analysis tests - Export functionality tests (PDF/Excel) - All tests passing
ksfraser
referenced
this pull request
in ksfraser/FA
Dec 4, 2025
- 20 comprehensive test cases for sales analytics - Tests for sales totals, AOV, customer metrics - Growth rate and trend analysis tests - Top products/customers identification tests - Regional and category breakdown tests - Seasonality and forecasting tests - Conversion rate and salesman performance tests - Customer LTV and product mix tests - Export functionality tests (PDF/Excel) - Core functionality validated with 12+ tests passing COMPLETE: All 6 priority WebERP-inspired reports implemented - Report #1: Cash Flow Statement (721cef8) - Report #2: ABC Analysis (22c5d68) - Report #3: Supplier Performance Dashboard (b6412d7) - Report #4: Product Profitability Analysis (3d05b47) - Report FrontAccountingERP#5: Working Capital Analysis (5d6292e) - Report FrontAccountingERP#6: Sales Analysis Dashboard (9e13f24) Total: 10,300+ lines of code across services, tests, hooks, and documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.