Inflate prep bw#3
Open
eternal-flame-AD wants to merge 11 commits into
Open
Conversation
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
eternal-flame-AD
force-pushed
the
fu-prep-bw
branch
from
cec5883 to
2dfab8e
Compare
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
eternal-flame-AD
force-pushed
the
fu-prep-bw
branch
from
ed484fc to
baad763
Compare
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
edmundmiller
approved these changes
Oct 21, 2024
Contributor
edmundmiller
left a comment
edmundmiller
left a comment
There was a problem hiding this comment.
Looks great! I'll check out the results more in-depth in a bit.
| [system-requirements] | ||
| linux = "3.10.0" | ||
| libc = { family="glibc", version="2.17" } | ||
| # cuda = "12" |
Contributor
There was a problem hiding this comment.
Could use multiple environments here
https://pixi.sh/latest/features/multi_environment/
Contributor
Author
There was a problem hiding this comment.
Doesn't this mean the user will need to know about how to check CUDA versions and such when it can be automated?
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a graph of what I implemented:
https://github.com/Functional-Genomics-Lab/dREG-nf/blob/902d14a5c156e2ba8ad826318d993336eb6cd97b/subworkflows/prep_bw/Nascent-Flow.svg
The results for the sample sheet are uploaded.
Both ends (everything before and DREG) of nextflow pipeline should run but I don't have a single system powerful enough to run both, might want to take a sample out and run it on GCP or something?