Fix Halcyonite shrine money not draining when using shared money.#246
Open
OnuxNemori wants to merge 3 commits intomasterfrom
Open
Fix Halcyonite shrine money not draining when using shared money.#246OnuxNemori wants to merge 3 commits intomasterfrom
OnuxNemori wants to merge 3 commits intomasterfrom
Conversation
Current method might be a bit heavy due to using sphereSearch and searching again from the object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current fix is not ideal. Working on a better. Essentially a patch for the current issue by drawing a sphere around the shrine to check how many players are in range. Use this value to drain from the total pool based on the current drain value.
Fixes #235