Skip to content

Fix HTTP transport cleanup during Unity reload #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JOY wants to merge 1 commit into from
Closed

Fix HTTP transport cleanup during Unity reload #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Fixed
- Made HTTP transport stop cleanup idempotent during Unity domain reloads, avoiding disposed `HttpListener` errors when reload cleanup runs after the listener has already been closed.
- Recognize Windows `HttpListenerException` address-in-use error codes and messages during restart retry detection.

## [0.3.4] - 2026-05-20

### Added
Expand Down
15 changes: 13 additions & 2 deletions Editor/MCP/Server/HttpMCPTransport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,19 +94,27 @@ public Task StopAsync()

public void Stop()
{
if (!_isRunning) return;
if (!_isRunning && _listener == null) return;
try
{
_cts?.Cancel();
_listener?.Stop();
_listener?.Close();
_isRunning = false;
PluginDebugLogger.Log("[Funplay MCP Server] HTTP transport stopped");
}
catch (ObjectDisposedException)
{
PluginDebugLogger.Log("[Funplay MCP Server] HTTP transport was already disposed");
}
catch (Exception ex)
{
Debug.LogError($"[Funplay MCP Server] Error stopping HTTP transport: {ex.Message}");
}
finally
{
_isRunning = false;
_listener = null;
}
}

private void CleanupFailedStart()
Expand All @@ -130,6 +138,9 @@ private static bool IsAddressInUse(Exception ex)
return ex is HttpListenerException listenerException &&
(listenerException.ErrorCode == 48 ||
listenerException.ErrorCode == 98 ||
listenerException.ErrorCode == 183 ||
listenerException.ErrorCode == 10048 ||
listenerException.Message.IndexOf("Only one usage", StringComparison.OrdinalIgnoreCase) >= 0 ||
listenerException.Message.IndexOf("Address already in use", StringComparison.OrdinalIgnoreCase) >= 0);
}

Expand Down