vm meta manifest#32
Conversation
Signed-off-by: Caleb Jones <caleb@calebgj.io>
Signed-off-by: Caleb Jones <caleb@calebgj.io>
Signed-off-by: Caleb Jones <caleb@calebgj.io>
isolating ch references. will move this to another crate later. Signed-off-by: Caleb Jones <caleb@calebgj.io>
Signed-off-by: Caleb Jones <caleb@calebgj.io>
Signed-off-by: Caleb Jones <caleb@calebgj.io>
Signed-off-by: Caleb Jones <caleb@calebgj.io>
|
@korewaChino most of those are intended to be temporary. just was getting it good enough so it would boot. If I was thinking better, I would have had it where the ctl could modify those values instead of hardcoding them lol. was intending on adding more later, but it wasnt necessary for just getting the the manifest arguably working. |
you can resolve those specific review comments then, mark them with a TODO or something too just in case |
|
ok cool |
|
oh forgot one thing. the operators stuff was based on the kubernetes pod affinity stuff. affinity isnt really finished though anyway, I just started writing it and then realized it is kinda integrated into the meta manifest. it arguably should be its own PR, but somehow i accidentally mixed it in. |
Signed-off-by: Caleb Jones <caleb@calebgj.io>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@korewaChino added todos, or did the review comments if they were simple. anything else, or good to merge? |
| VMCacheData { | ||
| actor_ref: actor_ref.clone(), | ||
| config: msg.config.clone() | ||
| config: Default::default() |
There was a problem hiding this comment.
empty default on cache miss?
There was a problem hiding this comment.
we need to decide if the migrate messages are ch specific or used for everything. the cache is now setup to store the overall meta-manifest and the current migrate messages are ch specific. so they don't have a copy of the manfiest. we also could just get a copy from the old vm, but im not 100% sure if we want to rely on getting a copy from there.
Signed-off-by: Caleb Jones <caleb@calebgj.io>
Signed-off-by: Caleb Jones <caleb@calebgj.io>
|
@korewaChino is this good to merge? Several other parts will need to be added later, but having the meta manifest at all is blocking several other issues. I rather get the minimal working solution merged and we get the other parts working later then try to get this perfect. |
|
approved |
3 participants
No description provided.