feat(contracts): add native loss and metric semantics - #21
Draft
GBeurier wants to merge 8 commits into
Draft
Conversation
…contracts # Conflicts: # crates/dag-ml-py/python/dag_ml/_dag_ml.abi3.so # docs/contracts/training_contract_conformance_pack.v1.json # docs/contracts/training_replay_contract_conformance_pack.v1.json # parity/training/generate_training_replay_fixtures.py # parity/training/tests/test_training_replay_contracts.py # scripts/validate_training_replay_contracts.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LossSpec,MetricSpec, distinct role references, and one generic implementation descriptor with opaque local registry keysIndependent review
8206fcc: approved with three documentation followups7c83262: approved, no findingsfcd1afc: approved with four schema/Rust parity followups7e9a363: approved, all prior findings resolved, no findingsf062bb7: approved; one low-severity followup records that the legacy regression scoring API lacks a real classification task-kind inputValidation
cargo test --workspace: 787 passed, 2 ignoredcargo clippy --workspace --all-targets -- -D warnings: cleanpython3 -m pytest parity/criteria/tests/test_criteria_contracts.py parity/training/tests/test_training_replay_contracts.py -q: 22 passedpython3 scripts/validate_contracts.py: passedpython3 scripts/validate_training_replay_contracts.py: passedStack
Depends on draft PR #20 (
agent/loss-runtime-integration).Followups