feat(external-sources): add application connection controls - #2169
Merged
Conversation
Make review decisions direct and authoritative across GUI and TUI, clarify disclosure and empty states, and avoid unnecessary snapshot projection work.
limityan
force-pushed
the
yanzhn/external-app-connection-v2
branch
from
August 8, 2026 14:37
9e74705 to
1b956c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the first end-to-end External AI Application connection experience:
Product experience
The default screen answers three questions only: which applications were found, whether each one is connected, and what action the user can take.
review allow, multi-iteminclude/excludeplusreview apply, andreview denyto keep everything disabled.The UI keeps the existing five application statuses. There is no wizard, modal stack, second state machine, new manager/store, or additional persistent user preference model.
Architecture and compatibility
bitfun-product-domainsowns behavior-light V2 DTOs, validation, and the shared status/action reducer.bitfun-coreprojects V2 state from the existing workspace external-source owner and preference store./wsand Shared TUI remain explicitly unsupported rather than falling back to controller-local state.Complexity and performance controls
No latency claim is made; these are allocation and lookup-path constraints verified in code and focused tests.
Verification
Latest focused verification after rebasing onto
GCWing/main:pnpm run type-check:webpnpm --dir src/web-ui buildpnpm run verify:monaco-assetsapplication_review_: 2 tests passedexternal_: 72 unit tests and 1 terminal integration passedpnpm run i18n:auditpnpm run appearance:contract-auditpnpm run theme:color-audit:allgit diff --checkThe V2 product-domain, App Server protocol/client, Desktop command, Peer Host, and boundary suites were also completed during the PR implementation. Known local warnings are pre-existing dead-code/import, chunk-size, and MSVC linker warnings.
Non-goals
Reviewer focus
Please focus review on preference migration, Host/workspace identity, strict V1/V2 negotiation, authoritative review rebinding, and partial batch outcomes.