fix(agent): make goal lifecycle available to every primary agent - #2180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation / Impact
Follow-up to #2178 and #2009. The earlier fix covered Cowork only. A full audit found the same UI/tool mismatch in the Assistant workspace (Claw), DeepResearch, Team, custom primary agents, external-source primary agents, and user profiles that removed one of the lifecycle tools.
The composer can activate a goal independently of a model tool call. A primary agent must therefore always be able to inspect and finish that goal, while child agents must not gain an independent thread-goal lifecycle.
Verification
cargo test --locked -p bitfun-agent-runtime --lib— 284 passedbitfun-coretests for built-in modes, custom modes, external primary/subagent projection, mode-profile overrides, and primary/subagent runtime policy — all passedpnpm --dir src/web-ui run test:run src/flow_chat/session-drivers/useComposerCapabilities.test.ts— 2 passedpnpm run type-check:webpnpm run check:core-boundariespnpm run check:repo-hygienegit diff --checkReviewer Notes
ACP sessions intentionally do not receive BitFun-local goal tools. The renderer now hides the local goal affordance and skips backend goal refreshes there; an ACP-native slash command with the same text can still be sent to the ACP agent.
AI-assisted; fully tested for the changed primary-agent goal capability contract.