fix(ci): pass public key when signing Windows installer - #2189
Merged
wgqqqqq merged 1 commit intoAug 10, 2026
Conversation
wgqqqqq
marked this pull request as ready for review
August 10, 2026 08:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TAURI_UPDATER_PUBKEYto the versioned Windows installer signing step.Root cause
The versioned Windows installer signing step supplied the private key and password but omitted
BITFUN_SIGNING_PUBKEY.scripts/sign-release-assets.shcreated the signature and then failed its mandatory self-verification because the public key was empty.Impact
Manual Desktop Package release runs can sign and self-verify the versioned Windows installer before uploading release assets.
Verification
pnpm run check:github-confignode --test scripts/check-github-config.test.mjsgit diff --check